hanahmily commented on code in PR #927:
URL:
https://github.com/apache/skywalking-banyandb/pull/927#discussion_r2674839668
##########
banyand/backup/lifecycle/service.go:
##########
@@ -152,11 +265,125 @@ func (l *lifecycleService) Serve() run.StopNotify {
})
if err != nil {
l.l.Error().Err(err).Msg("failed to register lifecycle
migration schedule")
+ close(done)
return done
}
+
+ // Wait for either migration completion or server stop
+ go func() {
+ select {
+ case <-done:
+ // Migration completed
+ case <-l.stopCh:
+ // Server stopped
+ close(done)
+ }
+ }()
Review Comment:
fix this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
