hanahmily commented on code in PR #44:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/44#discussion_r2684574409
##########
chart/values.yaml:
##########
@@ -248,6 +248,104 @@ cluster:
## @param cluster.etcdEndpoints List of etcd endpoints
##
etcdEndpoints: []
+
+ ## @section Node Registry Configuration for Service Discovery
+ ##
+ nodeRegistry:
Review Comment:
```suggestion
nodeDiscovery:
```
##########
chart/values.yaml:
##########
@@ -248,6 +248,104 @@ cluster:
## @param cluster.etcdEndpoints List of etcd endpoints
##
etcdEndpoints: []
+
+ ## @section Node Registry Configuration for Service Discovery
+ ##
+ nodeRegistry:
+ ## @param cluster.nodeRegistry.mode Node discovery mode (etcd, dns)
+ ## Default: etcd
+ ##
+ mode: "etcd"
+
+ ## @section Etcd Mode Configuration
+ ##
+ etcd:
+ ## @param cluster.nodeRegistry.etcd.namespace Namespace in etcd for node
registration
+ ## Default: banyandb
+ ##
+ namespace: "banyandb"
+
+ ## @param cluster.nodeRegistry.etcd.nodeRegistryTimeout Timeout for node
registration
+ ## Default: 2m
+ ##
+ nodeRegistryTimeout: "2m"
+
+ ## @param cluster.nodeRegistry.etcd.fullSyncInterval Interval for full
state synchronization
+ ## Default: 30m
+ ##
+ fullSyncInterval: "30m"
Review Comment:
```suggestion
etcd:
```
Move them to "etcd-client." Etcd has two distinct roles, so placing its
client-side configuration here is inappropriate.
##########
chart/values.yaml:
##########
Review Comment:
Update
"[values-lifecycle.yaml](https://github.com/apache/skywalking-banyandb-helm/blob/master/chart/values-lifecycle.yaml)"
as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
