Copilot commented on code in PR #13666:
URL: https://github.com/apache/skywalking/pull/13666#discussion_r2689160006
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBBrowserLogQueryDAO.java:
##########
@@ -70,7 +71,8 @@ public void apply(StreamQuery query) {
if (Objects.nonNull(category)) {
query.and(eq(BrowserErrorLogRecord.ERROR_CATEGORY,
category.getValue()));
}
-
+ query.setOrderBy(
+ new
AbstractQuery.OrderBy(AbstractQuery.Sort.DESC));
Review Comment:
For consistency with other StreamQuery implementations in the codebase,
consider using `new StreamQuery.OrderBy(AbstractQuery.Sort.DESC)` instead of
`new AbstractQuery.OrderBy(AbstractQuery.Sort.DESC)`. Other stream query DAOs
such as BanyanDBAlarmQueryDAO and BanyanDBProfileThreadSnapshotQueryDAO use
StreamQuery.OrderBy for the same purpose.
```suggestion
new
StreamQuery.OrderBy(AbstractQuery.Sort.DESC));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
