Copilot commented on code in PR #941:
URL:
https://github.com/apache/skywalking-banyandb/pull/941#discussion_r2692599094
##########
banyand/backup/lifecycle/service.go:
##########
@@ -141,8 +141,8 @@ func (l *lifecycleService) FlagSet() *run.FlagSet {
flagS.StringVar(&l.lifecycleCertFile, "lifecycle-cert-file", "", "the
TLS cert file")
flagS.StringVar(&l.lifecycleKeyFile, "lifecycle-key-file", "", "the TLS
key file")
flagS.StringVar(&l.lifecycleHost, "lifecycle-grpc-host", "", "the host
of lifecycle server listens")
- flagS.Uint32Var(&l.lifecycleGRPCPort, "lifecycle-grpc-port", 17912,
"the port of lifecycle server listens")
- flagS.Uint32Var(&l.lifecycleHTTPPort, "lifecycle-http-port", 17913,
"the port of lifecycle http api listens")
+ flagS.Uint32Var(&l.lifecycleGRPCPort, "lifecycle-grpc-port", 17914,
"the port of lifecycle server listens")
+ flagS.Uint32Var(&l.lifecycleHTTPPort, "lifecycle-http-port", 17915,
"the port of lifecycle http api listens")
Review Comment:
The CHANGES.md file should be updated to document this port change, as
mentioned in the PR description checklist. This is a breaking change for users
who might have hardcoded these ports in their deployment scripts or
configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
