hanahmily commented on code in PR #948:
URL:
https://github.com/apache/skywalking-banyandb/pull/948#discussion_r2703003342
##########
banyand/internal/sidx/interfaces.go:
##########
@@ -88,6 +89,8 @@ type QueryRequest struct {
Order *index.OrderBy
MinKey *int64
MaxKey *int64
+ MinTimestamp *int64 // Unix nanoseconds - for part-level selection only
+ MaxTimestamp *int64 // Unix nanoseconds - for part-level selection only
Review Comment:
They are not used by anyone.
##########
banyand/internal/sidx/interfaces.go:
##########
@@ -108,6 +111,8 @@ type ScanQueryRequest struct {
OnProgress ScanProgressFunc
MinKey *int64
MaxKey *int64
+ MinTimestamp *int64 // Unix nanoseconds - for part-level selection only
+ MaxTimestamp *int64 // Unix nanoseconds - for part-level selection only
Review Comment:
They are not referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
