This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git
The following commit(s) were added to refs/heads/main by this push:
new 67cb3eaa bugfix(fodc): Correct flag name typo from 'container-name' to
'container-names' (#949)
67cb3eaa is described below
commit 67cb3eaa71d1b2ba9a56dddc17050fd69da78593
Author: Fine0830 <[email protected]>
AuthorDate: Mon Jan 19 19:07:33 2026 +0800
bugfix(fodc): Correct flag name typo from 'container-name' to
'container-names' (#949)
---
fodc/agent/internal/cmd/root.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fodc/agent/internal/cmd/root.go b/fodc/agent/internal/cmd/root.go
index 5f421a27..7667425d 100644
--- a/fodc/agent/internal/cmd/root.go
+++ b/fodc/agent/internal/cmd/root.go
@@ -92,7 +92,7 @@ func init() {
"FODC Proxy gRPC address")
rootCmd.Flags().StringVar(&nodeRole, "node-role", "",
"Role of this BanyanDB node. Valid values: liaison,
datanode-hot, datanode-warm, datanode-cold, etc. Must match the node's actual
role in the cluster.")
- rootCmd.Flags().StringSliceVar(&containerNames, "container-name",
[]string{},
+ rootCmd.Flags().StringSliceVar(&containerNames, "container-names",
[]string{},
"Names of the containers corresponding to each
poll-metrics-port. Must have one-to-one correspondence with
poll-metrics-ports.")
rootCmd.Flags().StringVar(&podName, "pod-name", "",
"Name of the pod to use for the BanyanDB node's pod name. Used
as part of AgentIdentity for agent identification.")
@@ -122,7 +122,7 @@ func runFODC(_ *cobra.Command, _ []string) error {
return fmt.Errorf("poll-metrics-ports cannot be empty")
}
if len(containerNames) > 0 && len(containerNames) !=
len(pollMetricsPorts) {
- return fmt.Errorf("container-name count (%d) must match
poll-metrics-ports count (%d)", len(containerNames), len(pollMetricsPorts))
+ return fmt.Errorf("container-names count (%d) must match
poll-metrics-ports count (%d)", len(containerNames), len(pollMetricsPorts))
}
metricsEndpoints := generateMetricsEndpoints(pollMetricsPorts)