wu-sheng commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-helm/pull/47#discussion_r2704878956
##########
chart/values.yaml:
##########
@@ -976,16 +976,15 @@ cluster:
containerSecurityContext: {}
resources:
## @param cluster.fodc.agent.resources.requests Resource requests for
Agent
- requests: []
+ requests: {}
## @param cluster.fodc.agent.resources.limits Resource limits for Agent
- limits: []
- ## @param cluster.fodc.agent.grpcPort GRPC port for Agent sidecar (not
used - agent connects outbound to proxy)
- grpcPort: 17914
- ## @param cluster.fodc.agent.httpPort HTTP port for Agent sidecar
(prometheus-listen-addr flag)
- httpPort: 17915
+ limits:
Review Comment:
For FODC, I think we should consider default values? It is unreasonable to
provide unlimit FODC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
