Copilot commented on code in PR #13679:
URL: https://github.com/apache/skywalking/pull/13679#discussion_r2711230417
##########
oap-server-bom/pom.xml:
##########
@@ -60,7 +60,7 @@
<freemarker.version>2.3.31</freemarker.version>
<javaassist.version>3.25.0-GA</javaassist.version>
<vavr.version>0.10.3</vavr.version>
- <groovy.version>4.0.15</groovy.version>
+ <groovy.version>5.0.0</groovy.version>
Review Comment:
Groovy 5.0.0 represents a major version upgrade from 4.0.15. While the PR
description indicates thorough local testing, it would be beneficial to verify
that this is indeed the intended GA (General Availability) version. Groovy 5.x
introduces some breaking changes from 4.x, and while the tests reportedly pass,
consider documenting any behavioral differences or migration notes for future
reference, especially since this affects DSL parsing in critical analyzer
modules.
```suggestion
<groovy.version>4.0.15</groovy.version>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
