Copilot commented on code in PR #262:
URL: https://github.com/apache/skywalking-eyes/pull/262#discussion_r2792872122


##########
assets/languages.yaml:
##########
@@ -2414,6 +2414,10 @@ Inno Setup:
   tm_scope: source.inno
   ace_mode: text
   language_id: 167
+Inko:
+  extensions:
+    - ".inko"

Review Comment:
   The Inko language entry is missing several fields that are typically present 
in language definitions. According to the file header comments (lines 6-30), 
the following fields should be considered:
   
   1. `type` field - Should be either "data", "programming", "markup", "prose", 
or nil. Looking at neighboring entries like "Inno Setup" (line 2410) and "Io" 
(line 2422), programming languages typically have `type: programming`.
   
   2. `language_id` field - This is an integer field present in all language 
entries in the file (as evidenced by the comprehensive search results). It's 
described as "language-name-independent indexed field" and is required.
   
   3. `tm_scope` field - This represents the TextMate scope and should be set 
to "none" if there's no grammar. This field is present in nearly all entries.
   
   4. `ace_mode` field - This is the Ace Mode for highlighting and should be 
set to "text" if a mode doesn't exist. This field is present in all entries.
   
   These fields should be added to make the Inko entry consistent with other 
language definitions in the file.
   ```suggestion
   Inko:
     type: programming
     extensions:
       - ".inko"
     tm_scope: none
     ace_mode: text
     language_id: 100000000
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to