eye-gu opened a new issue, #13707:
URL: https://github.com/apache/skywalking/issues/13707

   ### Search before asking
   
   - [x] I had searched in the 
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Apache SkyWalking Component
   
   BanyanDB (apache/skywalking-banyandb)
   
   ### What happened
   
   1. The min/max values are encoded using convert.Int64ToBytes(), but the 
lower/upper values are encoded using encoding.Int64ToBytes(), so it is not 
possible to directly compare the byte arrays
   2. During the initialization of index.NewIntRangeOpts(), the lower/upper 
values are converted to float using numeric.Int64ToFloat64(). However, within 
the range method, they are directly converted to int using int64(), which does 
not equal the original int64 value
   3. If max is less than lower, or min is greater than upper, it should return 
true, indicating to skip
   
   ### What you expected to happen
   
   The encoding of min/max and lower/upper is correct and consistent. If max is 
less than lower, or min is greater than upper, return true to indicate skipping
   
   ### How to reproduce
   
   Adding indexRule and indexRuleBinding of TYPE_SKIPPING to stream, using 
BINARY_OP_GT or BINARY_OP_LT condition query, but it should skip but didn't 
skip, resulting in the query consuming more resources
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a pull request to fix on your own?
   
   - [x] Yes I am willing to submit a pull request on my own!
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to