ButterBright commented on code in PR #978:
URL:
https://github.com/apache/skywalking-banyandb/pull/978#discussion_r2853552603
##########
api/proto/banyandb/database/v1/rpc.proto:
##########
@@ -358,21 +358,13 @@ message GroupRegistryServiceUpdateResponse {}
message GroupRegistryServiceDeleteRequest {
// group is the name of the group to delete.
string group = 1;
- // dry_run indicates whether to perform a dry run without actually deleting
data.
- // When true, returns what would be deleted without making changes.
- bool dry_run = 2;
Review Comment:
I find dry_run not quite helpful, as it only executes the info collection
process.
##########
api/proto/banyandb/database/v1/rpc.proto:
##########
@@ -358,21 +358,13 @@ message GroupRegistryServiceUpdateResponse {}
message GroupRegistryServiceDeleteRequest {
// group is the name of the group to delete.
string group = 1;
- // dry_run indicates whether to perform a dry run without actually deleting
data.
- // When true, returns what would be deleted without making changes.
- bool dry_run = 2;
// force indicates whether to force delete the group even if it contains
data.
// When false, deletion will fail if the group is not empty.
- bool force = 3;
+ bool force = 2;
}
// GroupRegistryServiceDeleteResponse is the response for deleting a group.
-message GroupRegistryServiceDeleteResponse {
- // deleted indicates whether the group was deleted.
- bool deleted = 1;
- // task_id is the ID of the background deletion task.
- string task_id = 2;
-}
+message GroupRegistryServiceDeleteResponse {}
Review Comment:
The deleted and task_id field are not necessary either. We can use the group
name to query the deletion progress and the response can indicate whether the
group has been deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
