wankai123 commented on code in PR #13726:
URL: https://github.com/apache/skywalking/pull/13726#discussion_r2888592243
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java:
##########
@@ -100,19 +101,43 @@ public ConfigList dumpBootingConfigurations(String
keywords4MaskingSecretsOfConf
(providerName, providerConfiguration) ->
providerConfiguration.getProperties().forEach(
(key, value) -> {
- for (final String keyword : keywords) {
- if
(key.toString().toLowerCase().contains(keyword.toLowerCase())) {
- value = "******";
- }
+ if (value instanceof Properties) {
+ Properties properties = (Properties) value;
+ properties.forEach((k, v) -> {
+ String configKey = moduleName + "." +
providerName + "." + key + "." + k;
+ String configValue =
maskConfigValue(configKey, v.toString(), keywords);
+ configList.put(configKey, configValue);
+ });
+ } else {
+ String configKey = moduleName + "." +
providerName + "." + key;
+ String configValue =
maskConfigValue(key.toString(), value.toString(), keywords);
Review Comment:
updated 108 to `k.toString()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
