Copilot commented on code in PR #13910:
URL: https://github.com/apache/skywalking/pull/13910#discussion_r3409207492
##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -432,7 +432,7 @@ OAP will query the data from the "hot and warm" stage by
default if the "warm" s
| - | - | nodeSelector | Specifying
target nodes for this stage.
| SW_STORAGE_BANYANDB_RECORDS_WARM_NODE_SELECTOR | type=warm |
| - | cold | - | The cold stage
settings.
| - | - |
| - | - | shardNum | Shards Number
for for this stage.
| SW_STORAGE_BANYANDB_RECORDS_COLD_SHARD_NUM | 1 |
-| - | - | segmentInterval | Segment
Interval Days for this stage.
| SW_STORAGE_BANYANDB_RECORDS_COLD_SI_DAYS | 3
|
+| - | - | segmentInterval | Segment
Interval Days for this stage.
| SW_STORAGE_BANYANDB_RECORDS_COLD_SI_DAYS | 4
|
Review Comment:
This page updates the default `segmentInterval` values, but
`docs/en/setup/backend/storages/banyandb.md` still shows the old defaults
(`records` cold 3, `metricsMinute` cold 5, `metricsHour` warm 7 and cold 15).
Please update that doc too so users see consistent defaults across the docs.
##########
docs/en/banyandb/stages.md:
##########
@@ -31,14 +31,15 @@ The lifecycle stages configuration is under each group
settings of the `bydb.yml
nodeSelector:
${SW_STORAGE_BANYANDB_GM_MINUTE_WARM_NODE_SELECTOR:"type=warm"}
cold:
shardNum: ${SW_STORAGE_BANYANDB_GM_MINUTE_COLD_SHARD_NUM:2}
- segmentInterval: ${SW_STORAGE_BANYANDB_GM_MINUTE_COLD_SI_DAYS:5}
+ segmentInterval: ${SW_STORAGE_BANYANDB_GM_MINUTE_COLD_SI_DAYS:6}
Review Comment:
The example snippet in this doc uses a `metricsMin` group and
`SW_STORAGE_BANYANDB_GM_MINUTE_*` env vars, but the shipped `bydb.yml` uses
`metricsMinute` and `SW_STORAGE_BANYANDB_METRICS_MINUTE_*`. Keeping this
example aligned with the actual config avoids confusing users and makes the
updated default (`..._COLD_SI_DAYS:6`) discoverable in the right place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
