wu-sheng opened a new pull request, #13925: URL: https://github.com/apache/skywalking/pull/13925
### Remove the always-on alarm-to-event conversion (`EventHookCallback`) `EventHookCallback` was wired unconditionally in `NotifyHandler.init()` (not part of `AlarmHooksType`, no config, no off switch), so every triggered alarm was synthesized into the events pipeline as an `Alarm` (`Type.Error`) / `AlarmRecovery` (`Type.Normal`) event via `EventAnalyzerService.analyze(...)`. This conflated two distinct concepts: **alarm is alarm, event is only from event**. After this change, events originate only from real event sources (agents, SkyWalking CLI, Kubernetes Event Exporter). Alarms remain fully available through the alarm store (`getAlarm` / `queryAlarms`) and the configured alarm hooks (Webhook/gRPC/Slack/WeChat/DingTalk/Feishu/WeLink/PagerDuty/Discord). Notes: - No feedback loop existed (events persist as Records; alarms fire only off the Metrics stream; there is no OAL source for the `EVENT` scope), so this is a clean removal, not a correctness fix. - The read-side correlation (`AlarmQuery.findRelevantEvents`, the `AlarmMessage.events` GraphQL field) is **kept** — it surfaces real events on the alarmed entity as root-cause context and is consistent with the principle. - Removed the now-dead `event-analyzer` dependency from `server-alarm-plugin` to complete the decoupling. Changes: - Delete `EventHookCallback` and its registration in `NotifyHandler`; delete `EventHookCallbackTest`. - Drop the `event-analyzer` dependency from `server-alarm-plugin/pom.xml`. - Remove the `Alarm` row from the "Known Events" table in `docs/en/concepts-and-designs/event.md` (it was the only event sourced "from internal SkyWalking OAP", contradicting the doc's own framing). - Update the alarm/baseline e2e expected files and the e2e guide recipe that asserted the synthetic `Alarm` event. - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
