wu-sheng opened a new pull request, #13926:
URL: https://github.com/apache/skywalking/pull/13926
### Extend `GET /inspect/entities` to inspect a metric persisted by any OAP
(foreign metric)
`/inspect/entities` previously enumerated entities only for metrics
**defined on the queried OAP**. This extends it so a metric persisted by *any*
OAP — one this node never loaded the OAL/MAL/runtime-rule for — can be
inspected when the caller supplies the metric's `valueColumn` + `valueType`.
- The storage backend resolves the physical index/table/group from its **own
running config** — no DB schema / table-metadata read:
- **Elasticsearch** — merged `metrics-all` index + `metric_table`
discriminator.
- **JDBC** — probes the node's function tables by the `table_name`
discriminator.
- **BanyanDB** — synthesizes a read-only measure schema.
- `entity_id` is decoded **structurally** (service / 2nd-level / relations)
with a generic `name` leaf; scope is no longer required for the foreign path.
- Locally-defined metrics keep the **exact** field names, scope, and
`mqeEntity` (behavior unchanged).
- Reads are optimistic — errors surface to the caller; a metric unknown
locally without `valueColumn`/`valueType` returns a clear `400` steering the
caller to the foreign path.
`swctl admin inspect entities` gains `--value-column` / `--value-type`
(apache/skywalking-cli#230); `SW_CTL_COMMIT` is bumped to the cli commit that
ships them, and a 2-OAP inspect e2e (aware + foreign) is wired across BanyanDB
/ ES / PostgreSQL.
- [x] This is an API extension, not a SWIP-level feature — no design doc.
- [x] Update the documentation to include this new feature.
(`docs/en/setup/backend/admin-api/inspect.md`)
- [x] Tests (UT + E2E) are added to verify the new feature.
(`EntityDecoderTest` + `test/e2e-v2/cases/inspect/` across
BanyanDB/ES/PostgreSQL)
- [x] Update the [`CHANGES`
log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
