This is an automated email from the ASF dual-hosted git repository. mrproliu pushed a commit to branch disable-metrics-fetch in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git
commit 2d5b37173a6fc299e97e262c97add248506d7de0 Author: mrproliu <[email protected]> AuthorDate: Mon Jun 29 19:17:34 2026 +0800 disable the lifecycle metrics collector if the container has disabled --- CHANGES.md | 1 + chart/templates/cluster_data_statefulset.yaml | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index a3cfa38..1e12ccb 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -10,6 +10,7 @@ Release Notes. - Remove etcd support (breaking change). If upgrading, remove `etcd-client.*` and `cluster.*.tls.etcdSecretName` from your values overrides. +- Disable the lifecycle metrics collector if the container has disabled. 0.6.0 ----------------- diff --git a/chart/templates/cluster_data_statefulset.yaml b/chart/templates/cluster_data_statefulset.yaml index d22e3e8..9b21e15 100644 --- a/chart/templates/cluster_data_statefulset.yaml +++ b/chart/templates/cluster_data_statefulset.yaml @@ -306,9 +306,15 @@ spec: args: - --proxy-addr={{ template "banyandb.fullname" $ }}-fodc-proxy-grpc:{{ $.Values.cluster.fodc.proxy.grpcSvc.port }} - --pod-name=$(POD_NAME) + {{- if $roleConfig.lifecycleSidecar.enabled }} - --container-names=data,lifecycle - --poll-metrics-ports=2121,17915 - --cluster-state-ports=17912,17914 + {{- else }} + - --container-names=data + - --poll-metrics-ports=2121 + - --cluster-state-ports=17912 + {{- end }} - --lifecycle-port=17912 {{- if $roleConfig.lifecycleSidecar.enabled }} - --lifecycle-report-dir={{ default "/tmp/lifecycle-reports" $roleConfig.lifecycleSidecar.reportDir }}
