wu-sheng opened a new pull request, #88: URL: https://github.com/apache/skywalking-horizon-ui/pull/88
## Why A live-review pass over the Live debugger surfaced three issues in the LAL/MAL/OAL views: - the LAL pipeline-matrix's **frozen first column drifted off** with the rest of the grid on horizontal scroll instead of staying pinned; - clicking a source line to jump highlighted **only the step label**, not the row it maps to; - a tall result was **trapped in a fixed-height inner scroll box** rather than letting the page scroll. ## What - **Frozen column pins.** `.lal__matrix` gains `width: max-content` alongside `min-width: 100%` — the standard frozen-column idiom. `min-width: 100%` alone caps the grid's sticky containing block at the scroll-port width, so `position: sticky; left: 0` had nothing to pin against past one viewport; sizing to content fixes it. The matrix keeps its own bounded `overflow:auto`, so the sticky binds there (not to `.dv`). - **Whole-row flash.** Jumping flashes the entire matching step row (label outline + every record cell), via a `lal__cell--rowflash` class gated on the same `highlightedStepKey`. - **On-palette washes.** The pinned-column and row-flash backgrounds use `color-mix(in srgb, var(--rr-accent …) N%, var(--rr-bg))` — replacing a hardcoded off-palette `rgba(143,175,199,…)`. Opaque over `--rr-bg` (not `transparent`) so cells scrolling under the sticky column can't bleed through it. - **Page flow.** `.dv` (DebugView) and `.dbg` (LiveDebuggerView) drop their fixed-height/inner-`overflow` so MAL/LAL/OAL scroll the whole page for tall captures (the shell `main` owns the scroll). Short results still fill the viewport. LAL keeps its by-design internal matrix scroll for the frozen column. ## Validation - type-check (4 packages), lint + source-budget, **116 UI + 162 BFF** unit tests, build (ui + bff), license-check, i18n:validate — all green. - Verified in faithful exact-CSS reproductions (headless Chrome): the frozen column pins on x-scroll **and** the header on y-scroll (both axes simultaneously); the page scrolls (`main` scrollHeight ≫ clientHeight) with **no** inner `.dv`/`.dbg` scroll; re-checked the LAL sticky still holds after `.dv` became content-height. - Adversarial multi-agent review: unanimous ship-as-is — no regression; `color-mix` is already used in 28 places (DebugMal ships the identical `--rr-accent 20%` pattern); narrow-content `1fr` distribution, header/badge, and specificity/order all confirmed intact. - Caveat: debugger captures are `localStorage`-only, so these were validated against faithful structural mocks + the live env's real container chain, plus live confirmation on the running stack — not a headless replay of a saved session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
