hanahmily commented on code in PR #1201:
URL:
https://github.com/apache/skywalking-banyandb/pull/1201#discussion_r3526265667
##########
.mcp.json:
##########
@@ -0,0 +1,15 @@
+{
+ "mcpServers": {
+ "banyandb": {
Review Comment:
**[minor] Please confirm install-location resolution.** This still uses
`cwd: "."` + `args: ["./mcp/dist/index.js"]`. The new
`.agents/plugins/marketplace.json` (`source.path: "./"`) suggests the repo root
is the plugin root, which would make this correct — but could you confirm the
plugin loader resolves `./mcp/dist/index.js` relative to the installed plugin
dir (not just a repo checkout)? A one-line note in
`docs/operation/mcp/plugin.md` would settle it.
##########
.claude-plugin/plugin.json:
##########
@@ -0,0 +1,37 @@
+{
Review Comment:
**[minor] Duplicated manifest still unaddressed.**
`.claude-plugin/plugin.json` and `.codex-plugin/plugin.json` remain ~95%
identical (only `version` differs). Either generate one from the other, or add
a short comment/README note on how they're kept in sync, to avoid future drift.
Fine as a follow-up if you'd rather not touch it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
