wu-sheng commented on a change in pull request #3769: httpasyncclient plugin
adpter for ES. if out is exit span, do not propagating context
URL: https://github.com/apache/skywalking/pull/3769#discussion_r341685657
##########
File path:
apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/HttpAsyncRequestExecutorInterceptor.java
##########
@@ -48,12 +48,14 @@
@Override
public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class<?>[] argumentsTypes, MethodInterceptResult result) throws
Throwable {
HttpContext context = CONTEXT_LOCAL.get();
+ Boolean isOutNotExit = CONTEXT_LOCAL_NOT_EXIT.get();
Review comment:
`ContextManager.activeSpan().isExit()` should be available if this is in the
main thread, and`CONTEXT_LOCAL_NOT_EXIT` is not required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
