This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch segment-order in repository https://gitbox.apache.org/repos/asf/skywalking.git
View the commit online: https://github.com/apache/skywalking/commit/e72883250f62680183b8834b0c4e59b55a6b6390 The following commit(s) were added to refs/heads/segment-order by this push: new e728832 Add comment. e728832 is described below commit e72883250f62680183b8834b0c4e59b55a6b6390 Author: Wu Sheng <[email protected]> AuthorDate: Wed Nov 20 20:49:22 2019 +0800 Add comment. --- .../apache/skywalking/oap/server/core/query/TraceQueryService.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TraceQueryService.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TraceQueryService.java index 2291ea3..1a1cd0f 100644 --- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TraceQueryService.java +++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TraceQueryService.java @@ -392,7 +392,9 @@ public class TraceQueryService implements Service { }); /** * In some cases, there are segment fragments, which could not be linked by Ref, - * because of sampling, agent fail safe, segment lost, even bug. + * because of two kinds of reasons. + * 1. Multiple leaf segments have no particular order in the storage. + * 2. Lost in sampling, agent fail safe, segment lost, even bug. * Sorting the segments makes the trace view more readable. */ rootSpans.sort(Comparator.comparing(span -> new Long(span.getStartTime())));
