wu-sheng commented on a change in pull request #17: [Feature] Add endpoint
command, refactor Makefile to cross build target
URL: https://github.com/apache/skywalking-cli/pull/17#discussion_r352342592
##########
File path: commands/metrics/linear/linear-metrics.go
##########
@@ -50,8 +55,15 @@ var Command = cli.Command{
step := ctx.Generic("step")
metricsName := ctx.String("name")
+ var id *string = nil
+
+ if serviceID := ctx.String("id"); serviceID != "" {
+ id = &serviceID
+ }
Review comment:
linear metrics can work will service, instance and endpoint too. I think
this is not wrong here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
