wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r356412315
########## File path: apm-sniffer/optional-plugins/armeria-0.85.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/armeria/ArmeriaClientInterceptor.java ########## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.apm.plugin.armeria; + +import java.lang.reflect.Method; +import java.net.URI; + +import com.linecorp.armeria.client.Clients; +import com.linecorp.armeria.common.HttpHeadersBuilder; +import com.linecorp.armeria.common.HttpMethod; +import com.linecorp.armeria.common.HttpRequest; +import com.linecorp.armeria.common.util.SafeCloseable; +import io.netty.util.AsciiString; +import org.apache.skywalking.apm.agent.core.context.CarrierItem; +import org.apache.skywalking.apm.agent.core.context.ContextCarrier; +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.context.tag.Tags; +import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan; +import org.apache.skywalking.apm.agent.core.context.trace.SpanLayer; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor; +import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; + +/** + * @author kezhenxu94 + */ +public abstract class ArmeriaClientInterceptor implements InstanceMethodsAroundInterceptor { + private static final String KEY_SAFE_CLOSEABLE = "SAFE_CLOSEABLE"; + + protected void beforeMethod(final URI uri, final HttpMethod httpMethod, final String path) { + final ContextCarrier contextCarrier = new ContextCarrier(); + final String remotePeer = uri.getHost() + ":" + uri.getPort(); + + final AbstractSpan exitSpan = ContextManager.createExitSpan(path, contextCarrier, remotePeer); + + exitSpan.setComponent(ComponentsDefine.ARMERIA); + exitSpan.setLayer(SpanLayer.HTTP); + Tags.HTTP.METHOD.set(exitSpan, httpMethod.name()); + + ContextManager.getRuntimeContext().put(KEY_SAFE_CLOSEABLE, Clients.withHttpHeaders(headers -> { Review comment: Thanks for sharing the context. Didn't expect the Armeria is using ThreadLocal to process the ClientRequestContext. Most RPC frameworks using a local variable ref. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services