[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add pom exclude license file dir.

[GitBox]

aderm commented on a change in pull request #4217: Add pom exclude license file 
dir.
URL: https://github.com/apache/skywalking/pull/4217#discussion_r365640282
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -450,6 +450,12 @@
                         
<exclude>tools/dependencies/known-oap-backend-dependencies.txt</exclude>
                         <exclude>apm-checkstyle/CHECKSTYLE_HEAD</exclude>
 
+                        <!-- generated file from oap or webapp logs files -->
+                        <exclude>**/apm-dist/logs/**</exclude>
 
 Review comment:
   <img width="900" alt="WX20200113-114517@2x" 
src="https://user-images.githubusercontent.com/2892433/72232137-2cec4800-35fa-11ea-8503-91999a8c7224.png";>
   
   In some cases, compilation problems can cause error log generation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services