wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r366911621
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java ########## @@ -388,5 +390,26 @@ */ public static int HTTP_PARAMS_LENGTH_THRESHOLD = 1024; } + + public static class Grpc { + /** + * If this config is false, only client spans of peer which configured in {@link Grpc#INCLUDED_CLIENT_TRACING_PEERS} + * will be collected. In this mode {@link Grpc#EXCLUDED_CLIENT_TRACING_PEERS} will override {@link Grpc#INCLUDED_CLIENT_TRACING_PEERS}. + * <p> + * If this config is true, only client spans of peer which configured in {@link Grpc#EXCLUDED_CLIENT_TRACING_PEERS} + * will not be collected. In this mode {@link Grpc#INCLUDED_CLIENT_TRACING_PEERS} will override {@link Grpc#EXCLUDED_CLIENT_TRACING_PEERS}. + */ + public static boolean DEFAULT_CLIENT_TRACING_ENABLE = false; + + /** + * Included client tracing peers. gRPC plugin will collect client spans of configured config. + */ + public static List<String> INCLUDED_CLIENT_TRACING_PEERS = new LinkedList<>(); + + /** + * Excluded client tracing peers. gRPC plugin will not collect client spans of configured config. + */ + public static List<String> EXCLUDED_CLIENT_TRACING_PEERS = new LinkedList<>(); Review comment: Do you forget to remove all these? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services