wu-sheng commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r367918152
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java ########## @@ -30,22 +37,139 @@ // task data private final ProfileTask task; - // task real start time - private final long startTime; + // record current profiling count, use this to check has available profile slot + private final AtomicInteger currentProfilingCount = new AtomicInteger(0); + + // profiling segment slot + private volatile ThreadProfiler[] profilingSegmentSlots = new ThreadProfiler[Config.Profile.MAX_PARALLEL]; Review comment: Same as before, don't use Config in the field initialization. Use it in the constructor. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services