wu-sheng commented on a change in pull request #4264: Refactor
SnifferConfigInitializer and related componets with new features in JDK8+
URL: https://github.com/apache/skywalking/pull/4264#discussion_r367977687
##########
File path:
apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/ConfigInitializer.java
##########
@@ -105,30 +114,18 @@ private static List convert2List(String value) {
}
class ConfigDesc {
- private LinkedList<String> descs = new LinkedList<String>();
+ private Stack<String> descs = new Stack<>();
Review comment:
`class Stack<E> extends Vector<E>`. There are a lot of sync in the Vector. I
prefer don't use it in any case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
