wu-sheng commented on a change in pull request #4220: sniffer processing
profile task and report status and snapshot
URL: https://github.com/apache/skywalking/pull/4220#discussion_r367980372
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionService.java
##########
@@ -151,7 +202,7 @@ public long getLastCommandCreateTime() {
*/
private String checkProfileTaskSuccess(ProfileTask task) {
Review comment:
In this case, I prefer to return a `Result` class, rather than exception.
Profiling is happening in a high payload scenario, but Exception is a heavy OP.
We should avoid it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
