kezhenxu94 commented on a change in pull request #4220: sniffer processing profile task and report status and snapshot URL: https://github.com/apache/skywalking/pull/4220#discussion_r368215552
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ThreadProfiler.java ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.agent.core.profile; + +import com.google.common.base.Objects; +import org.apache.skywalking.apm.agent.core.conf.Config; +import org.apache.skywalking.apm.agent.core.context.TracingContext; +import org.apache.skywalking.apm.agent.core.context.ids.ID; + +import java.util.ArrayList; +import java.util.concurrent.TimeUnit; + +/** + * @author MrPro + */ +public class ThreadProfiler { + + // current tracing context + private final TracingContext tracingContext; + // current tracing segment id + private final ID traceSegmentId; + // need to profiling thread + private final Thread profilingThread; + // profiling execution context + private final ProfileTaskExecutionContext executionContext; + + // profiling time + private long profilingStartTime; + private long profilingMaxTimeMills; + + // after min duration threshold check, it will start dump + private ProfilingStatus profilingStatus = ProfilingStatus.READY; + // thread dump sequence + private int dumpSequence = 0; + + public ThreadProfiler(TracingContext tracingContext, ID traceSegmentId, Thread profilingThread, ProfileTaskExecutionContext executionContext) { + this.tracingContext = tracingContext; + this.traceSegmentId = traceSegmentId; + this.profilingThread = profilingThread; + this.executionContext = executionContext; + this.profilingMaxTimeMills = TimeUnit.MINUTES.toMillis(Config.Profile.MAX_DURATION); + } + + /** + * If tracing start time greater than {@link ProfileTask#getMinDurationThreshold()}, then start to profiling trace + */ + public void startProfilingIfNeed() { + if (System.currentTimeMillis() - tracingContext.createTime() > executionContext.getTask().getMinDurationThreshold()) { + this.profilingStartTime = System.currentTimeMillis(); + this.profilingStatus = ProfilingStatus.PROFILING; + } + } + + /** + * Stop profiling status + */ + public void stopProfiling() { + this.profilingStatus = ProfilingStatus.STOPPED; + } + + /** + * dump tracing thread and build thread snapshot + * + * @return snapshot, if null means dump snapshot error, should stop it + */ + public TracingThreadSnapshot buildSnapshot() { + if (!isProfilingProfilingContinuable()) { + return null; + } + + long currentTime = System.currentTimeMillis(); + // dump thread + StackTraceElement[] stackTrace; + try { + stackTrace = profilingThread.getStackTrace(); + + // stack depth is zero, means thread is already run finished + if (stackTrace.length == 0) { + return null; + } + } catch (Exception e) { + // dump error ignore and make this profiler stop + return null; + } + + // if is first dump, check is can start profiling + if (dumpSequence == 0 && (!executionContext.isStartProfileable())) { + return null; + } + + int dumpElementCount = Math.min(stackTrace.length, Config.Profile.DUMP_MAX_STACK_DEPTH); + + // use inverted order, because thread dump is start with bottom + final ArrayList<String> stackList = new ArrayList<>(dumpElementCount); + for (int i = dumpElementCount - 1; i >= 0; i--) { + stackList.add(buildStackElementCodeSignature(stackTrace[i])); + } + + String taskId = executionContext.getTask().getTaskId(); + return new TracingThreadSnapshot(taskId, traceSegmentId, dumpSequence++, currentTime, stackList); + } + + /** + * build thread stack element code signature + * + * @return code sign: className.methodName:lineNumber + */ + private String buildStackElementCodeSignature(StackTraceElement element) { + return element.getClassName() + "." + element.getMethodName() + ":" + element.getLineNumber(); Review comment: It's ok to me, "Unknown Source" takes more bandwidth then "-1" after all ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
