wu-sheng commented on a change in pull request #4264: Refactor SnifferConfigInitializer and related componets with new features in JDK8+ URL: https://github.com/apache/skywalking/pull/4264#discussion_r368275410
########## File path: apm-commons/apm-util/src/main/java/org/apache/skywalking/apm/util/PropertyPlaceholderHelper.java ########## @@ -83,17 +83,13 @@ * Replaces all placeholders of format {@code ${name}} with the corresponding property from the supplied {@link * Properties}. * - * @param value the value containing the placeholders to be replaced + * @param value the value containing the placeholders to be replaced Review comment: Please revert this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services