aderm commented on a change in pull request #4292: Improve ES query performance URL: https://github.com/apache/skywalking/pull/4292#discussion_r372785778
########## File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/query/AggregationQueryEsDAO.java ########## @@ -96,7 +96,7 @@ public AggregationQueryEsDAO(ElasticSearchClient client) { SearchSourceBuilder sourceBuilder = SearchSourceBuilder.searchSource(); BoolQueryBuilder boolQueryBuilder = QueryBuilders.boolQuery(); - sourceBuilder.query(boolQueryBuilder); + sourceBuilder.query(QueryBuilders.boolQuery().filter(boolQueryBuilder)); boolQueryBuilder.must().add(QueryBuilders.rangeQuery(Metrics.TIME_BUCKET).lte(endTB).gte(startTB)); boolQueryBuilder.must().add(QueryBuilders.termQuery(EndpointInventory.SERVICE_ID, serviceId)); Review comment: [https://www.elastic.co/guide/en/elasticsearch/reference/7.5/query-dsl-filtered-query.html](url) [https://www.elastic.co/guide/en/elasticsearch/client/net-api/7.x/writing-queries.html](url) > The benefit of executing a query in a filter context is that Elasticsearch is able to forgo calculating a relevancy score, as well as cache filters for faster subsequent performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services