wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r373958815
########## File path: oap-server/server-bootstrap/src/main/resources/application.yml ########## @@ -146,6 +146,11 @@ storage: # password: ${SW_STORAGE_PASSWORD:} # database: ${SW_STORAGE_DATABASE:skywalking} # metadataQueryMaxSize: ${SW_STORAGE_H2_QUERY_MAX_SIZE:5000} +# recordDataTTL: ${SW_STORAGE_RECORD_DATA_TTL:7} # keeps 7 days +# minuteMetricsDataTTL: ${SW_STORAGE_MINUTE_METRICS_DATA_TTL:64800} # Unit is minute, keeps 45 days +# hourMetricsDataTTL: ${SW_STORAGE_HOUR_METRICS_DATA_TTL:1080} # Unit is hour, keeps 45 days +# dayMetricsDataTTL: ${SW_STORAGE_DAY_METRICS_DATA_TTL:45} # Unit is day, keeps 45 days +# monthMetricsDataTTL: ${SW_STORAGE_MONTH_METRICS_DATA_TTL:18} # Unit is month, keeps 18 months Review comment: If these are using the as same unit as the core module, you shouldn't add them. You could use the core's. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services