wu-sheng commented on a change in pull request #4335: Provide profile analyze
query
URL: https://github.com/apache/skywalking/pull/4335#discussion_r377052937
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.java
##########
@@ -50,9 +133,28 @@ public static ProfileAnalyzation
analyze(List<ProfileStack> stacks) {
.filter(s -> CollectionUtils.isNotEmpty(s.getStack()))
.collect(Collectors.groupingBy(s -> s.getStack().get(0),
ANALYZE_COLLECTOR));
- ProfileAnalyzation analyzer = new ProfileAnalyzation();
- analyzer.setTrees(new ArrayList<>(stackTrees.values()));
- return analyzer;
+ return new ArrayList<>(stackTrees.values());
}
+ private IProfileThreadSnapshotQueryDAO getProfileThreadSnapshotQueryDAO() {
+ if (profileThreadSnapshotQueryDAO == null) {
+ profileThreadSnapshotQueryDAO =
moduleManager.find(StorageModule.NAME).provider().getService(IProfileThreadSnapshotQueryDAO.class);
+ }
+ return profileThreadSnapshotQueryDAO;
+ }
+
+ private static class SequenceSearch {
+ LinkedList<SequenceRange> ranges = new LinkedList<>();
+ int totalSequenceCount;
+ }
+
+ private static class SequenceRange {
Review comment:
Even for an inner class, please use set/get, rather than accessing fields
directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
