wu-sheng commented on issue #4228: Support Browser protocol at OAP URL: https://github.com/apache/skywalking/pull/4228#issuecomment-585008534 > For error logs, if backend can't cache/persistent the context, how do we query error details? Error details are needed to analyse code error location. Context is not the log itself. Context is which PV has an error log already or not. Think in this way there are 1 -> 1,000,000,000 page accesses, each one of them has random [0, 5) errors. Then now, the client-js reports an error log, if following your proposal, the backend need to query all existing 1m access and check whether this page has been counted as an error, then error count could be +1. But meanwhile, there is other 1m accesses happen in the next several seconds. Could you imagine how much payload this design gives the system? That is typical and classics error when we talked about distributed systems and distributed statistics. The backend design must make sure affordable resource usage. This principle keeps as always in agent upstream protocol and tracing analysis in all language agents. That is why I said `Theoretically, it could help the calculation, but in engineering practice, it can't`. We increase a little complexity at the agent side, but tradeoff higher performance at the backend and storage. This makes SkyWalking could widely used and cost reasonable VMs(A.K.A. money for the end users) Hope this explanation could make you more clear.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
