wu-sheng commented on a change in pull request #19: Add firstReportedError field URL: https://github.com/apache/skywalking-data-collect-protocol/pull/19#discussion_r378298953
########## File path: browser/BrowserPerf.proto ########## @@ -45,15 +45,17 @@ message BrowserPerfData { // Page path in the browser, mostly it is URI, without parameter string pagePath = 4; int32 pagePathId = 5; + // Then the PV with error is only calculated when firstReportedError is true. + bool firstReportedError = 6; Review comment: After release, such as 7.0.0, we only add field at the last seq for keeping the compatible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services