kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r379902233
##########
File path: .github/workflows/e2e.yaml
##########
@@ -71,15 +73,19 @@ jobs:
./mvnw --batch-mode -Dcheckstyle.skip -Drat.skip -T2
-Dmaven.compile.fork -Dmaven.compiler.maxmem=3072 -DskipTests clean install
./mvnw --batch-mode -f test/e2e/pom.xml -pl e2e-base clean install
- name: Cluster Tests (ES6/ZK/JDK8)
- run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh
e2e-cluster/e2e-cluster-test-runner
+ run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh
e2e-cluster/e2e-cluster-test-runner --storage=elasticsearch
+ - name: Cluster Tests (InfluxDB/ZK/JDK8)
+ run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh
e2e-cluster/e2e-cluster-test-runner --storage=influxdb
- name: Cluster With Gateway Tests (ES6/ZK/JDK8)
- run: export E2E_VERSION=jdk8-1.3 && bash -x test/e2e/run.sh
e2e-cluster-with-gateway/e2e-cluster-with-gateway-test-runner
+ run: export E2E_VERSION=jdk8-1.5 && bash -x test/e2e/run.sh
e2e-cluster-with-gateway/e2e-cluster-with-gateway-test-runner
Review comment:
> Why this doesn't have `--storage=elasticsearch`? What is the default? Or
what happens if no `--storage=`?
Not every e2e case is aware of the parameter `--storage`,
`e2e-cluster-with-gateway` is one of them, the parameter is introduced recently
and only `e2e-cluster` and `e2e-profile` are refactored then, IIRC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
