wu-sheng commented on issue #2: Finish the tracing core APIs URL: https://github.com/apache/skywalking-rust/pull/2#issuecomment-593192087 > Now span is allocated in the heap instead of the stack, that is not common practice because of the overhead of heap allocation. How do you expect the span is in the stack? Could you provide some examples? The span is unsized because of tags and logs. > About to close span, users should take care of closing span when they want to return workflow. It might bring potential bugs. Let's provide a closure method to wrap users' logic block into it, that's useful for Marco especially. Do you have an example? I think this could be optional, as a manual API core, I will keep the API as directly as possible without the unnecessary limits. This thing should be more suitable in `skywalking-agent` . WDYT?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
