wu-sheng commented on issue #4520: Enhanced Agent Hostname detection function URL: https://github.com/apache/skywalking/issues/4520#issuecomment-599890601 @gameover453 From the JDK discussion you referred, I am a little confused. They said, they provide reasonable logic for getLocalHost. Basically, SkyWalking doesn't care about which files you changed, it is about we are using JDK API. Different OSs have different implementation JDK, and we expect the return value is consistent. I still can't see reading a linux specific file makes more sense. I think we shouldn't argue about change which file, because we don't require for that, we treat JDK implementation projects/vendors at an expert level, definitely better than us.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
