hanahmily commented on pull request #4783:
URL: https://github.com/apache/skywalking/pull/4783#issuecomment-637939842


   > 2. How to use and active 
`oap-server/server-bootstrap/src/main/resources/fetcher-prom-rules/self.yaml`.
   
   Prometheus fetcher module will parser all rules located at 
`$CLASSPATH/fetcher-prom-rules` on the bootstrap phase automatically. 
   
   > 3. `self.yaml` seems will be packaged into bootstrap.jar as no package 
related change. Please confirm.
   
   I will move it to the dist module, we can update it in the `config` folder 
in the dist directory.
   
   > 4. Question, should we remove the s011y in this PR? It seems you have 
added the `self.yaml` to do this.
   
   Yes. I will remove so11y.
   
   > 5. `known-oap-backend-dependencies.txt` and 
`known-oap-backend-dependencies-es7.txt` are not updated, but based on the 
LICENSE changes, we should face the lib update. Please recheck, the CI will 
check the lib update through these two files.
   
   will add. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to