yu199195 commented on a change in pull request #4894:
URL: https://github.com/apache/skywalking/pull/4894#discussion_r437948493
##########
File path: apm-sniffer/apm-sdk-plugin/pom.xml
##########
@@ -47,6 +47,7 @@
<module>sharding-sphere-3.x-plugin</module>
<module>sharding-sphere-4.x-plugin</module>
<module>sharding-sphere-4.x-RC3-plugin</module>
+ <module>sharding-sphere-4.1.0-plugin</module>
Review comment:
Maybe they could merge into a module,like this:
sharding-sphere-plugin
---- sharding-sphere-3.x-plugin
---- sharding-sphere-4.x-plugin
---- sharding-sphere-4.x-RC3-plugin
---- sharding-sphere-4.1.0-plugin
What do you think, maybe there will be more submodules in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
