tuohai666 commented on a change in pull request #4894:
URL: https://github.com/apache/skywalking/pull/4894#discussion_r437974176



##########
File path: apm-sniffer/apm-sdk-plugin/pom.xml
##########
@@ -47,6 +47,7 @@
         <module>sharding-sphere-3.x-plugin</module>
         <module>sharding-sphere-4.x-plugin</module>
         <module>sharding-sphere-4.x-RC3-plugin</module>
+        <module>sharding-sphere-4.1.0-plugin</module>

Review comment:
       Hi Sheng,
   Yes, the class name and method name are so different almost every 
ShardingSphere release.
   As I know, 4.0.0 is different from 4.0.0-RC3, and 4.1.0 is differnent from 
4.0.1.
   For the 4.1.1 under releasing, same as 4.1.0, they can share a same plugin.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to