hanahmily commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449812378
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
.getService(MetricsCreator.class);
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
- new MetricsTag.Keys("metricName", "level", "dimensionality"), new
MetricsTag.Values(modelName, "1", "min")
+ new MetricsTag.Keys("metricName", "level", "dimensionality"), new
MetricsTag.Values(modelName, "1", "minute")
Review comment:
After a talk with sheng, I agree with renaming it. Pls, to search and
update other possible references more than `grafana.json`. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
