[GitHub] [skywalking] killGC commented on a change in pull request #4987: support sampleRate as Dynamic Configuration (#4968)

[GitBox]

killGC commented on a change in pull request #4987:
URL: https://github.com/apache/skywalking/pull/4987#discussion_r450264310



##########
File path: 
oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/parser/listener/TraceSegmentSampler.java
##########
@@ -25,7 +25,7 @@
  * ignored
  */
 public class TraceSegmentSampler {
-    private TraceServiceModuleConfig config;
+    private volatile TraceServiceModuleConfig config;

Review comment:
       Dynamic configuration will not modify 
TraceServiceModuleConfig#sampleRate，but modify TraceSampleRateWatcher#sampleRate




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org