[GitHub] [skywalking] amwyyyy opened a new pull request #5096: optimization MetricsEsDAO multiGet

[GitBox]

amwyyyy opened a new pull request #5096:
URL: https://github.com/apache/skywalking/pull/5096


   See this issues [#5039](https://github.com/apache/skywalking/issues/5039)
   
   The problem is because the es query times out
   
![image](https://user-images.githubusercontent.com/8274512/87400840-ed73d800-c5eb-11ea-8225-c5cd1e92d5a6.png)
   Cause duplicate service_traffic
   ```
   {
     "_index": "sw8_service_traffic-20200704",
     "_type": "type",
     "_id": "bWJwLWJvbnVzLWNhbGN1bGF0ZQ==.1",
     "_version": 1,
     "_score": 2,
     "_source": {
       "node_type": 0,
       "name": "mbp-bonus-calculate"
     }
   }
   
   {
     "_index": "sw8_service_traffic-20200706",
     "_type": "type",
     "_id": "bWJwLWJvbnVzLWNhbGN1bGF0ZQ==.1",
     "_version": 1,
     "_score": 2,
     "_source": {
       "node_type": 0,
       "name": "mbp-bonus-calculate"
     }
   }
   ```
   Then the server starts throw exception
   
![image](https://user-images.githubusercontent.com/8274512/87401584-e6999500-c5ec-11ea-99b6-d41aff1e4f7e.png)
   
   View server source code, under normal circumstances method "ids" the return 
should be less than or equal to the length of String[] ids. However, because 
service_traffic is repeated, one id can search two results, resulting in 
totalHits greater than the actual. So throw ArrayIndexOutOfBoundsException.
   
![image](https://user-images.githubusercontent.com/8274512/87401937-69225480-c5ed-11ea-9505-7a26640e0b7c.png)
   
![image](https://user-images.githubusercontent.com/8274512/87401899-5c056580-c5ed-11ea-9459-25627617e36c.png)
   
   ***We should guarantee the stability of es, but there will always be 
unexpected situations, hoping that skywalking is fault-tolerant. Because in the 
previous version, at most only some trace data was lost.***


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org