wu-sheng commented on issue #5549: URL: https://github.com/apache/skywalking/issues/5549#issuecomment-698077008
I think you don't understand how the JDBC works, `close` could be called anytime if the connection wants to. We build the operation name of MySQL span like this `return connectionInfo.getDBType() + "/JDBI/" + statementName + "/" + methodName;`. > I have implemented monitoring the time to create the pool, close the pool, get the connection from the pool, and close the connection from the pool. Is this appropriate? No, this seems not a right process. The pool should be initialized in the bootstrap stage, and only `get` and `return/close` in the process. If you are not familiar with the connection pool, why do you try to build a connection pool tracing plugin? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
