wu-sheng commented on a change in pull request #5628:
URL: https://github.com/apache/skywalking/pull/5628#discussion_r499239313
##########
File path:
oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReaderTest.java
##########
@@ -18,16 +18,23 @@
package org.apache.skywalking.oap.server.core.alarm.provider;
-import java.util.List;
+import
org.apache.skywalking.oap.server.core.alarm.provider.dingtalk.DingtalkSettings;
import org.junit.Assert;
import org.junit.Test;
-public class AlarmRuleInitTest {
+import java.util.List;
+
+import static org.hamcrest.CoreMatchers.any;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertNull;
+import static org.junit.Assert.assertThat;
+
+public class RulesReaderTest {
@Test
- public void testInit() {
+ public void testReadRules() {
Review comment:
But I have noticed this, maybe above is just a coverage issue? FYI
@kezhenxu94, any clue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
