[GitHub] [skywalking-client-js] arugal commented on a change in pull request #17: FIX: sslTime Not an int32 value

[GitBox]

arugal commented on a change in pull request #17:
URL: 
https://github.com/apache/skywalking-client-js/pull/17#discussion_r519313819



##########
File path: src/performance/perf.ts
##########
@@ -48,7 +48,7 @@ class PagePerf {
         // Synchronous load resources in the page
         resTime: parseInt(String(timing.loadEventStart - 
timing.domContentLoadedEventEnd), 10),
         // Only valid for HTTPS
-        sslTime: location.protocol.includes('https') ?
+        sslTime: location.protocol === 'https' && timing.secureConnectionStart 
> 0 ?

Review comment:
       
![image](https://user-images.githubusercontent.com/26432832/98461424-eef28d00-21e6-11eb-904b-5949e133f8d9.png)
   
   @qinhang3  It looks like `https:`, please confirm :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org