kezhenxu94 commented on a change in pull request #5800:
URL: https://github.com/apache/skywalking/pull/5800#discussion_r519429655



##########
File path: 
oap-server/server-receiver-plugin/receiver-proto/src/main/fbs/istio/node-info.fbs
##########
@@ -0,0 +1,48 @@
+/* Copyright 2020 Istio Authors. All Rights Reserved.

Review comment:
       > Could you leave a comment that implies the location and commit sha? It 
is too tricky to maintain the codes without them even though the original 
contributor like you doesn't figure it out after several months.
   Syncing is a more complicated topic, as there are a lot of unversioned 
protocol files in the repo, need to be discussed further.
   
   Comment is added




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to