kezhenxu94 opened a new pull request #5808: URL: https://github.com/apache/skywalking/pull/5808
<!-- ⚠️ Please make sure to read this template first, pull requests that doesn't accord with this template may be closed without notice. Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` --> <!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ==== ### Fix <bug description or the bug issue number or bug issue link> - [ ] Add a unit test to verify that the fix works. - [ ] Explain briefly about why the bug exists and how to fix it. ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== --> <!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ==== ### Add an agent plugin to support <framework name> - [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md) - [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml) - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets) ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== --> <!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ==== ### Improve the performance of <class or module or ...> - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java) - [ ] The benchmark result. ```text <Paste the benchmark results here> ``` - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here> ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== --> <!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ==== ### <Feature description> - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [ ] Tests(including UT, IT, E2E) are added to verify the new feature. - [ ] If it's UI related, attach the screenshots below. ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== --> ### Fix flaky LUA E2E test by working around the testcontainers bug The LUA E2E tests failed frequently after upgrading to testcontainers 1.15.0, the log shows that there is no enough disk space in GitHub Actions, and I found out that it's because we didn't specify the `openresty/openresty` tag in the `Dockerfile`, testcontainers pulls all images, hence run out of the disk space. I've filed an issue in testcontainers repo to confirm whether it's a bug, and work around this problem by specify the tag explicitly. ([Details](https://github.com/testcontainers/testcontainers-java/issues/3442)) The workaround can be verified by looking the [execution histories](https://github.com/apache/skywalking/actions?query=branch%3Aci%2Fdisk-problem) - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>. **NO**, but ref to https://github.com/testcontainers/testcontainers-java/issues/3442 - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/c2141978d1039375598a32418b75161a78da22c1/CHANGES.md). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org