sepe81 commented on code in PR #812:
URL: https://github.com/apache/struts/pull/812#discussion_r1430111114
##########
assembly/src/main/resources/template.vm:
##########
@@ -43,12 +43,12 @@ under the License.
<script src='http://struts.apache.org/highlighter/js/$hscript'
type='text/javascript'></script>
#end
- <script type="text/javascript">
+ <script>
SyntaxHighlighter.defaults['toolbar'] = false;
SyntaxHighlighter.all();
</script>
#end
- <script type="text/javascript" language="javascript">
+ <script language="javascript">
Review Comment:
```suggestion
<script>
```
Should the language attribute also be removed?
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#deprecated_attributes
states:
>Like the type attribute, this attribute identifies the scripting language
in use. Unlike the type attribute, however, this attribute's possible values
were never standardized. The type attribute should be used instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
