betodealmeida commented on a change in pull request #15614:
URL: https://github.com/apache/superset/pull/15614#discussion_r666687610



##########
File path: superset-frontend/src/views/CRUD/data/database/types.ts
##########
@@ -25,6 +25,7 @@ export type DatabaseObject = {
   // Connection + general
   id?: number;
   database_name: string;
+  name: string; // synonym to database_name

Review comment:
       We're setting `name` instead of `database_name` somewhere, so I had to 
add the property here. This is just a quick fix, ideally we should fix the code 
that sets `name` and make it set `database_name` instead.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to